fix: Properly represent multiple versions of the same custom resource #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dark0dave
requested changes
Sep 9, 2023
atzawada
force-pushed
the
atzawada-fix-multiple-versions
branch
3 times, most recently
from
2f33a3f
to
2c3f328
Compare
|
@dark0dave Sonar is flagging a couple of code smells...I am not sure that the suggested changes help the style of the tests in any way, but if you want me to make them I can |
atzawada
force-pushed
the
atzawada-fix-multiple-versions
branch
from
2c3f328
to
c954f76
Compare
|
This PR has not seen any activity in last 60 days and has been marked as stale |
dark0dave
approved these changes
Dec 22, 2023
Signed-off-by: Andy Zawada <atzawada@gmail.com>
Signed-off-by: Andy Zawada <atzawada@gmail.com>
Signed-off-by: Andy Zawada <atzawada@gmail.com>
dark0dave
force-pushed
the
atzawada-fix-multiple-versions
branch
from
c954f76
to
321d972
Compare
|
Looks like you'll need to format this. |
|
This PR has not seen any activity in last 60 days and has been marked as stale |
|
This PR was closed because it has been stalled for 90 days with no activity. |
|
@atzawada this is some functionality I need so I am running your fork -- are you by chance able to get this formatted so it can be merged? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a quick peek into the issue #515 that I opened earlier. Looks like it was an issue with how the Rego template was being rendered for additional custom resources. Simply combined the resource versions in the go code before passing it all off to the template.
If this approach is deemed ok, I will go back and write up some additional testing around this.