Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deviceUUID filter with DXVK_FILTER_DEVICE_UUID #2408

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

meladath
Copy link

@meladath meladath commented Dec 22, 2021

In relation to #2036.

Please suggest improvements if you know of any.

This uses the same check as the DXVK_FILTER_DEVICE_NAME, so if any part of the UUID matches, it allows the device to be created.

Does not check for - in the UUID, as UUID contained in vulkaninfo does not contain these chars, they are simply added into the output stream before being displayed to the user. The first section of UUID also contains PCI bus info so should be enough to correctly ID a GPU. See comments on the review in this PR for more information.

@Tiny-Paws
Copy link

Shouldn't ConvertUUID take a reference to uuid rather than a pointer ?

@meladath
Copy link
Author

meladath commented Sep 1, 2023

Could I get a review on this please? I have edited the OP to be more representative of the PR's current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants