345 - NHT: Users shall be able to create stats. #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlmcneary2
commented
Jun 29, 2019
rlmcneary2
commented
- Upgrade DB script adds a creatorId column to the DB.
- Added the creatorId to a stat to capture the user that created the stat.
- Logged in user's can now create stats.
- If a user is logged in they will see the delete icon for stats they created.
- If an admin is logged in they can delete stats that anyone has created.
- Updated the server to delete stats only when the stat was created by the current user or the current user is an admin.
rlmcneary2
requested review from
justinbmeyer,
tehfedaykin,
Amechi101 and
josh-bitovi
rlmcneary2
commented
Jul 2, 2019
| @@ -225,7 +225,7 @@ export const ViewModel = DefineMap.extend('GameDetailsVM', | |||
| * ``` | |||
| */ | |||
| showStatMenuFor: function(player, element, event){ | |||
| if(!this.session || !this.session.isAdmin()) { | |||
| if(!this.session.user) { | |||
There was a problem hiding this comment.
restore check for session existence
rlmcneary2
commented
Jul 2, 2019
| } | ||
|
|
||
| return function ( req, res, next ) { | ||
| if ( req.user ) { |
rlmcneary2
commented
Jul 2, 2019
| return Promise.all([stat, stat.get("creatorId")]); | ||
| }) | ||
| .then(([stat, creatorId]) => { | ||
| debugger; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.