Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance #334

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Improve performance #334

merged 1 commit into from
Sep 25, 2017

Conversation

imaustink
Copy link
Contributor

@imaustink imaustink commented Sep 19, 2017 •
edited
Loading

Implement can-compute-memoize to improve performance.

These changes focus on optimizing calls to osProjectContributionsMap. Before this change, loading the app resulted in hundreds or even thousands of calls, depending on the dataset, this has been reduced to six calls.

Closes #330

@imaustink imaustink force-pushed the 330-improve-performance branch 2 times, most recently from d3a80b1 to 92875af Compare September 19, 2017 21:18
@imaustink imaustink changed the title 330 improve performance Improve performance Sep 19, 2017
@imaustink imaustink force-pushed the 330-improve-performance branch 5 times, most recently from 2878fa5 to 9481c1f Compare September 21, 2017 22:11
@imaustink
Improve performance
faafb9b 
Implement caching to improve performance

Closes #330
bgando
bgando approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@bgando bgando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the can-compute-memoize technique you used and that you moved the totalPayouts from the contributionMonth model rather than contributionMonths.

@imaustink imaustink merged commit 1ea220c into staging Sep 25, 2017
@imaustink imaustink deleted the 330-improve-performance branch September 25, 2017 23:14
@imaustink imaustink mentioned this pull request Sep 25, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgando bgando bgando approved these changes

@justinbmeyer justinbmeyer Awaiting requested review from justinbmeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imaustink @bgando