Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steals boolean conditional loading is not working on SSR? #539

Closed
pYr0x opened this issue Jun 9, 2018 · 4 comments
Closed

steals boolean conditional loading is not working on SSR? #539

pYr0x opened this issue Jun 9, 2018 · 4 comments
Labels

Comments

@pYr0x
Copy link

pYr0x commented Jun 9, 2018

in relation to #537 i tried:

import "~/modules/fontawesome#?~./utils/is-node";

with

// Only Node.JS has a process variable that is of [[Class]] process
export default Object.prototype.toString.call(typeof process !== "undefined" ? process : 0) === "[object process]";

but i got the same error as in #537

using:
donejs: 2
steal: 1.11.6
steal-conditional: 1.1.1

cc @m-mujica @matthewp

@matthewp
Copy link
Contributor

Don't you want to not import fontawesome if it is node? So maybe you need a utils/is-not-node and use that instead.

@pYr0x
Copy link
Author

pYr0x commented Jun 11, 2018

i think this i related to stealjs/steal-conditional#58
the tidle is no meaning "src directory" it is meaning negation

@matthewp
Copy link
Contributor

Oh ok, so this bug is not specific to ssr then?

@pYr0x
Copy link
Author

pYr0x commented Jun 11, 2018

no, we can close this

@pYr0x pYr0x closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants