Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boolean negation not working #58

Open
pYr0x opened this issue Jun 9, 2018 · 2 comments
Open

boolean negation not working #58

pYr0x opened this issue Jun 9, 2018 · 2 comments
Labels
bug

Comments

@pYr0x
Copy link

pYr0x commented Jun 9, 2018

this line https://github.com/stealjs/steal-conditional/blob/master/conditional.js#L99 should before spliting the module in its parts.
https://github.com/stealjs/steal-conditional/blob/master/conditional.js#L88

donejs/done-ssr#539
@pYr0x pYr0x mentioned this issue Jun 11, 2018
Closed
@matthewp matthewp added the bug label Jun 11, 2018
@matthewp
Copy link
Member

@pYr0x Any chance you want to fix this one? ;-)

@leoj3n
Copy link

leoj3n commented Nov 10, 2018

Is this still an issue? I'm pretty sure ~ worked for me in a test project with a module at the root level.

pYr0x pushed a commit that referenced this issue Dec 13, 2018
- change negation to ^ #63
83a9449 
- fix issue with negation and es6 modules close #58
@pYr0x pYr0x mentioned this issue Dec 13, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewp @leoj3n @pYr0x