-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme: add doom-gruvbox-material #714
base: master
Are you sure you want to change the base?
Conversation
hey, this looks cool, but can we adjust the contrast option in this theme ?? I just saw your commit, it looks like you have taken the colors from [vim palette](https://github.com/sainnhe/gruvbox-material], I would suggest you instead take them from vs-code palette. as the vs-code was made for a GUI application, thus have wider color range. you can find both of the above mentioned color palette from this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the super late response. Would you mind rebasing this onto master
? I'm also keen on using the vscode colors instead (as @samyak039 suggested), but I don't mind merging this for now and fixing that later.
hey @ianyepan, if you don't mind, may I take it over from here ? PS. I really want gruvbox-material in my doom emacs. |
@samyak039 Hey Samyak, please go ahead -- just been busy lately and didn't have time to check my github issues as much as I want to. Let me know how it goes! |
@samyak039 not to be bothersome but are there any updates on this? |
@kristupas-gaidys nothing right now. I just got my first job. so busy with it. will do after some time. |
Perhaps pass the PR along to someone else.. |
You can copy the file added via this PR manually to your themes folder and have it working as it is right now. |
@apoorv569 it's not my PR to begin with :) |
This PR adds a new theme: Gruvbox Material, which is a port by sainnhe (https://github.com/sainnhe/gruvbox-material) that was inspired by the original Gruvbox, except using more subtle Material colors. Here is an example screenshot:
Gruvbox Material (this PR, more pastel, easier on the eyes)
Original doom-gruvbox (classic, more vibrant)