Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meltbus: Fix upper eight colours of vterm #767

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

spacefrogg
Copy link
Contributor

vterm produces the colours 8–15 from the face-background of the colours 0–7. Adapt the colours to make, e.g., brightblack visible again

Fixes #765


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • Any relevant issues or PRs have been linked to.

@gagbo
Copy link
Member

gagbo commented Aug 31, 2023

Did you check that it works in TUI? doom-lighten and doom-darken don't do anything to their argument when it's not in GUI

@spacefrogg
Copy link
Contributor Author

This is, how it looks like in vterm running inside a graphical emacs:
image

The next, when running vterm inside emacs -nw which runs inside another vterm.

image

So, you're right. It is only partially working. Suggestions?

@gagbo
Copy link
Member

gagbo commented Sep 8, 2023

I guess you can compute the colors that you like from GUI, and then hardcode the value in the theme, so you dodge the doom-darken/doom-lighten call.

You can evaluate (doom-lighten (doom-color 'red) 0.3) in a scratch buffer with the theme loaded to see the value (or use SPC h F to look at the faces and have the value directly there)

@spacefrogg
Copy link
Contributor Author

I fixed it (and some other things). First image shows vterm in GUI emacs:
image

Second image shows vterm in emacs -nw inside vterm:
image

vterm abuses the background colour of the first eight colours to
generate the upper eight colours.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meltbus: bright black text is invisible in vterm
2 participants