Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(base): replace :italic with :slant #841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(base): replace :italic with :slant #841

wants to merge 1 commit into from

Conversation

wyuenho
Copy link

@wyuenho wyuenho commented Oct 19, 2024 •
edited
Loading

:italic is not a font attribute

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to Doom's git conventions.
  • My changes are visual; I've included before and after screenshots.

Before

Screenshot 2024-10-19 at 4 51 15 PM

After

Screenshot 2024-10-19 at 4 52 23 PM

@hlissner hlissner added is:bug Something isn't working as intended theme:base Affects the base theme (i.e. all themes) labels Oct 20, 2024
@wyuenho wyuenho changed the title fix: replace :italic with :slant fix(base): replace :italic with :slant Oct 20, 2024
@hlissner hlissner added this to the v2.4.0 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlissner hlissner hlissner approved these changes

Assignees
No one assigned
Labels
is:bug Something isn't working as intended theme:base Affects the base theme (i.e. all themes)
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wyuenho @hlissner