fix(treemacs): inherit from variable-pitch face at most once #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `doom-themes-enable-treemacs-variable-pitch-labels` is executed every time `load-theme` gets called. Before this fix, each invocation would lead to the treemacs-*-faces gaining an `:inherit doom-themes-treemacs-variable-pitch-face` attribute. But inheriting from a face is not an idempotent operation, i.e., applying it more than once will lead to a different effect than applying it exactly once. For instance, if the face `variable-pitch` has the attribute `:height 1.2`, then inheriting from it 4 times will lead to a height of 1.2^4 ≈ 2 instead of 1.2. Loading 4 themes will therefore inadvertently double the font size in the treemacs buffer. With this fix, the inheritance is only applied once.
hlissner
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
doom-themes-enable-treemacs-variable-pitch-labelsisexecuted every time
load-themegets called.Before this fix, each invocation would lead to the treemacs-*-faces
gaining an
:inherit doom-themes-treemacs-variable-pitch-faceattribute. But inheriting from a face is not an idempotent operation,
i.e., applying it more than once will lead to a different effect than
applying it exactly once. For instance, if the face
variable-pitchhasthe attribute
:height 1.2, then inheriting from it 4 times will leadto a height of 1.2^4 ≈ 2 instead of 1.2. Loading 4 themes will therefore
inadvertently double the font size in the treemacs buffer.
With this fix, the inheritance is only applied once.