Fix missing "this" keyword in ToSystem and ToGeneric for 4d vector #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
@HurricanKai will let you take this one as it's maths (and should be fairly trivial :)) |
Perksey
pushed a commit
that referenced
this pull request
Nov 20, 2023
…1584) * start of adding missing this keyword in ToSystem and ToGeneric parameters for Vector4D<T> * Added missed "this" keyword in SystemNumericsExtensions * Added ToSystem and ToGeneric methods to public api for Vector4 and Vector4D<T>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Vector4D doesn't has the ToSystem function and Vector4 doesn't has the ToGeneric function, these functions in SystemNumericsExtensions class doesn't has the
thiskeyword, so... I'll try to fix it. It's my first contributing experience so I'm sorry if I will make mistakes