Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of MSBuild without Git #1596

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Allow use of MSBuild without Git #1596

merged 1 commit into from
Aug 17, 2023

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Jul 31, 2023

Fixes #1594

@Perksey Perksey mentioned this pull request Jul 31, 2023
Closed
@Perksey
Copy link
Member Author

Perksey commented Jul 31, 2023

Build hasn't fallen over immediately so this should be ready for review (1 LOC)

@Perksey Perksey marked this pull request as ready for review July 31, 2023 13:50
@Perksey Perksey requested a review from a team as a code owner July 31, 2023 13:50
Beyley
Beyley approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Beyley Beyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Beyley Beyley merged commit 3e737f2 into main Aug 17, 2023
5 of 6 checks passed
@Beyley Beyley deleted the hotfix/msbuild-no-git branch August 17, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beyley Beyley Beyley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Silk.NET Development Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails due to git invocation fail
2 participants
@Perksey @Beyley