-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MoltenVK #1623
Support MoltenVK #1623
Conversation
Working examples can be found here: https://github.com/zvasya/VulkanExample Updated packages are in the LocalPackages folder. |
@dotnet-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing contribution I wasn't expecting to see given the state of our iOS support! Thank you so much! There's a few comments mostly relating to process and deployment, and a couple of code comments. Hopefully shouldn't take too much time, again thank you so much for your work here.
src/Native/Silk.NET.MoltenVK.Native/build/netstandard2.0/Silk.NET.MoltenVK.Native.targets
Outdated
Show resolved
Hide resolved
Compile MoltenVK with Nuke take only necessary libraries into MoltenVK package instead of the full xcframework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Please keep it coming, super excited to get Silk.NET.Vulkan working on iOS out of the box.
add installing of ninja build system for compiling MoltenVK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go after this, thank you so much for your work!
Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
I'm probably missing context here - I'm not really surprised that this works, but I'd appreciate if the relevant context is added here or even better the new attribute has some comment to explain why it's necessary. (Using __Internal works fine for Sdl, right? Why is the attribute not necessary there?) |
We discuss this with Perksey at https://discord.com/channels/521092042781229087/607634593201520651/1149730272754020384 In two words: And without this condition there is compiler (linking) error for Mac Release. Same error would be if add Silk.Net.SDL package to Mac project. |
Fixed loading of the "__Internal" library for iOS, iOS Simulator and MacCatalyst using the GetMainProgramHandle method from Net7.0.
And add package with MoltenVK libraries