Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Refactor SilkTouch to Use Roslyn Workspaces + more #2288

Merged
merged 45 commits into from
Oct 10, 2024

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Oct 2, 2024

Summary of the PR

Refactors SilkTouch to make it fit for the future.

Related issues, Discord discussions, or proposals

Links go here.

Further Comments

ClangScraper is now a mod in its own right

It was too special and I wanted to ensure any major refactor made the core of SilkTouch nothing but a mod execution and documents pipeline, rather than being magical and tied to ClangSharp intrinsically.

Use Roslyn Workspaces

This is so we can make use of the Renamer which uses the semantic model to determine usages of the symbol we're renaming, rather than having to work all that context out ourselves. This is much slower, but more correct and fixes issues encountered in #2234 wherein the renames didn't propagate through thing->a->b for instance

Repository structure

As discussed in team talk.

Dependencies

Dependents

Supersedes

Perksey and others added 30 commits April 6, 2024 14:42
@Perksey Perksey changed the base branch from develop/3.0 to feature/sdl-bindings October 2, 2024 21:15
Copy link
Contributor

github-actions bot commented Oct 3, 2024

File Coverage
All files 3%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 14d3e58

@Perksey Perksey changed the base branch from feature/sdl-bindings to feature/new-3.0-repo-structure October 6, 2024 22:13
Perksey added a commit that referenced this pull request Oct 7, 2024
@Perksey Perksey force-pushed the feature/new-3.0-repo-structure branch from a76c488 to 2631cee Compare October 9, 2024 20:09
Base automatically changed from feature/new-3.0-repo-structure to develop/3.0 October 10, 2024 11:50
@Perksey Perksey marked this pull request as ready for review October 10, 2024 12:58
@Perksey Perksey requested a review from a team as a code owner October 10, 2024 12:58
@Perksey
Copy link
Member Author

Perksey commented Oct 10, 2024

This has been rebased and to the best of my knowledge and belief it's ready for review @curin. It's quite hard to review though, I'd focus on the SilkTouch changes. Most of the bindings changes are fiddling with usings or member ordering, which really I would like to somehow make deterministic so it doesn't pollute PRs like it has here.

@Perksey Perksey merged commit de89670 into develop/3.0 Oct 10, 2024
15 checks passed
@Perksey Perksey deleted the feature/silktouch-3.0-fit-for-future branch October 10, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants