Improve timely shutdown of directory partitions when snapshot transfer has been abandoned #9197
+102
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug preventing timely shutdown of silos with the experimental directory replacement implemented in #9103 in some cases.
Specifically, when leaving the cluster, replicas snapshot their directory partitions and wait for new owners to collect and acknowledge the snapshots. If the new owner decides to perform recovery instead of hand-off then the snapshot transfer is abandoned. Until this PR, there was no way to signal that the transfer had been abandoned. It is always safe to abandon a transfer, in which case recovery will be performed instead (at some added expense).
This PR tells the snapshot sender to abandon the snapshot in two scenarios:
Microsoft Reviewers: Open in CodeFlow