Add security comment to DictionaryWrapper.cs - #132640
Open
GrabYourPitchforks wants to merge 1 commit into
Open
Conversation
Added security comment regarding environment block handling.
GrabYourPitchforks
requested review from
adamsitnik
and
a lite review from Copilot
August 21, 2026 21:11
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a source comment in System.Diagnostics.Process’s internal DictionaryWrapper to clarify that the environment-variable validation performed in the indexer setter is not intended as a primary security mitigation.
Changes:
- Adds a security-context comment above the
Validatecalls inDictionaryWrapper.this[string].set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic newly added to
System.Diagnostics.Processappears to be security-sensitive, but it is not. This deserves a source code clarification.Ref: https://github.com/dotnet/core/blob/main/Documentation/security-foundations/baseline-security-assumptions.md#22-environment-variables-are-trusted-as-a-control-plane-mechanism