Trigger Characters missing in formatAfterKeyStroke #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
omnisharp-roslyn side : OmniSharp/omnisharp-roslyn#1042 |
ghost
removed
the
TheRealPiotrP
approved these changes
Dec 11, 2017
|
@TheRealPiotrP: Should there be a label for cross-cutting changes like these that depend on a new OmniSharp build? |
|
Should this be merged now? |
|
This is blocked on : OmniSharp/omnisharp-roslyn#1042 and microsoft/vscode#40235 |
|
@akshita31 still blocked? |
|
Is there anything blocking this? |
|
@DustinCampbell I haven't looked into this one for some time. Will take it up now. |
|
I am not sure what is the correct approach to deal with this. |
|
Any updates on when this will be merged? |
|
Any news on this? |
|
Any Updates on this? It shows it's been waiting to be merged for a while now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #1591
To ensure proper bracket styling, entering '{' should trigger a format request. Also '\n' is one of the expected characters for triggering the format request. It was present in omnisharp-roslyn but not present as trigger character on the vscode side.
Please review : @DustinCampbell @TheRealPiotrP @rchande