Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rzls to launch using standard dotnet #5855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaredpar
Copy link
Member

This PR has two purposes:

  1. Carving a path out where by we can ship rzls in a non-self contained fashion.
  2. Unify the dotnet acquisition and launch process between the razor and roslyn servers

This is my first every TypeScript PR so please be gentle 😄

This PR has two purposes:

1. Carving a path out where by we can ship rzls in a non-self contained
   fashion.
2. Unify the `dotnet` acquisition and launch process between the razor
   and roslyn servers

This is my first every TypeScript PR so please be gentle 😄
@jaredpar jaredpar marked this pull request as ready for review June 23, 2023 16:11
@jaredpar jaredpar requested review from a team as code owners June 23, 2023 16:11
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize, I'm about to change this code in #5837

It should however have a re-usable piece for you to use in Razor (a dotnetHostExecutableResolver)

@dibarbet
Copy link
Member

@jaredpar
Copy link
Member Author

Well at least it looks like I was on the right track here.

maryamariyan added a commit that referenced this pull request Feb 1, 2024
- Updates where to pick up dotnet.exe.
- Contributes to making rzls move away from being self-contained.
- Unifies how roslyn and razor servers acquire dotnet path/env variables.
- Picks up leftover changes from #5855 into main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants