Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OmniSharp to 1.39.12 #7445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Aug 15, 2024

In addition to updating O#, this also changes where the latest builds of O# are discovered. The C# extension will now download O# from its GitHub releases.

@JoeRobich JoeRobich requested a review from a team as a code owner August 15, 2024 21:19
} catch (error) {
this.eventStream.post(new InstallationFailure('getLatestVersionInfoFile', error));
throw error;
}
}

public async fetchLatestReleases(urlString: string): Promise<any> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly the existing downloadFile with cancellation and progress reporting removed.


public constructor(
private downloader: OmnisharpDownloader,
private platformInfo: PlatformInformation,
// Only the tests set this. Instead of making this configurable,
// we should probably just mock the HTTP requests, not create an entire mock HTTP server.
private serverUrl: string = 'https://roslynomnisharp.blob.core.windows.net'
private serverUrl: string | undefined = undefined
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue to use this for tests to override. However, now that we need separate urls for downloading builds and finding latest version, we do not initialize this and allow each method to supply the correct production url.

// Omnisharp versions are always after the last '-'.
// e.g. we want omnisharp-win-x86 from omnisharp-win-x86-1.39.3.zip
const lastDash = fileName.lastIndexOf('-');
fileName = fileName.substr(0, lastDash);
return fileName;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH release builds do not contain the version number in the filename.

@JoeRobich JoeRobich force-pushed the dev/jorobich/omnisharp-github-releases branch from b655b51 to 305fc7d Compare October 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant