Remove double lookups on SizeLimitedCache<K, V>, improve performance #9949
+34
−87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4828
Description
While checking out
SizeLimitedCache<K, V>
yesterday, I've noticed the double lookups on the dictionary and today I've found there's already a corresponding issue for it, hence we should fix it for optimal performance as this is used with glyphs/fonts.ArgumentNullException
directly.Remove
had even three lookups, so now it just has one.readonly
have been adjusted.Node
uses auto properties now.10 capacity, 15 unique additions first, 20 lookups
Customer Impact
Improved perfomance.
Regression
No.
Testing
Local build, tests with the class.
Risk
Low, just basically compiler warnings.
Microsoft Reviewers: Open in CodeFlow