Replace use of ArrayList with List<T> in BamlMapTable for performance #9967
+105
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
h3xds1nz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces 4x
ArrayListcollections withList<T>for improved performance and increased type safety.I've also introduced
initsetters for the respective properties so they can be used as part of theCloneoperation and the underlying fields can be converted toreadonly. Rest are just NULL check removals coming from theascasting pattern or simply redundant as the values in the lists are always from freshly initialized types, no NULLs are inserted.Sample benchmark showing difference between
ArrayListandList<T>with reference type can be found f.e. in #9432.Customer Impact
Improved performance, cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
Low, just type swaps.
Microsoft Reviewers: Open in CodeFlow