#211, currentTotal variable is used till 4.6, therefore retrieved data… #212
Conversation
… stored in priceValue 211, currentTotal variable is used till 4.6, therefore retrieved data stored in priceValue --fixed typeof --fixed code
| // This should not happen on Confirm Contribution, but seems to on 4.6 for some reason. | ||
| //return true; | ||
| } | ||
| currentTotal = $('#pricevalue').data('raw-total'); |
There was a problem hiding this comment.
currentTotal is used till CiviCRM version 4.6.x. In 4.7 currentTotal is never set and hence the code tries to validate payment details which should not be in case total amount is 0. An alternate method which will work for all version of civicrm is to retrieve data stored in pricevalue.
| // This is also hit when "Going back", but we already have stripe_token. | ||
| debugging('ozlkf'); | ||
| // This should not happen on Confirm Contribution, but seems to on 4.6 for some reason. | ||
| //return true; | ||
| } |
There was a problem hiding this comment.
If currentTotaal == 0 and there are no additional participants, shouldn't we return true? I'm not sure why that is commented out in the original or in your fix.
There was a problem hiding this comment.
The comments tell the story.....it was breaking 4.6 transactions.
//This should not happen on Confirm Contribution, but seems to on 4.6 for some reason.
Do you mind testing this PR with that line uncommented on 4.6?
There was a problem hiding this comment.
@h-c-c maybe it's better to have separate branches for 4.6 and 4.7? This issue still exists and there doesn't seem to be any progress on testing it on 4.6.
btw, this commit progressivetech@b255663 is probably the better one to create as a PR.
|
I'm not running any 4.6 instances at the moment - but since there is a separate 4.6-dev and 4.7-dev branches, perhaps this could be committed to the 4.7-dev branch? |
|
That was abandoned a while ago. I've been working to support both in this branch. If you're interested in contributing upstream, you should check out buildkit. You can spin up a civi instance in a one liner! |
… stored in priceValue