Support implicit PostgreSQL foreign key references - #1101
Open
yzxcj797 wants to merge 1 commit into
Open
Conversation
Resolve REFERENCES clauses without an explicit column list to the referenced table's primary key, including composite keys. Fixes drawdb-io#669
|
@yzxcj797 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #669.
Summary
CREATE TABLEimports that omit referenced columns using a narrowly scoped compatibility markerScope and compatibility
This follows the importer's existing ordering and name-resolution behavior: the referenced table must appear earlier in the input, and this compatibility path handles unqualified table names. Explicit
REFERENCES table(column)clauses are unchanged.Testing
npm test- 3 passednpm run lintnpm run build- passed (existing dependencyevaland bundle-size warnings only)npx prettier --check .github/workflows/build.yml package.json src/components/EditorHeader/Modal/Modal.jsx src/utils/importSQL/postgres.js src/utils/importSQL/postgresImplicitReferences.js test/postgres-implicit-references.test.jsgit diff --checkAI assistance
OpenAI Codex assisted with diagnosis, implementation, tests, and review. I reviewed the final behavior and diff, ran the validation above, and take responsibility for the submitted change.