Expand PostgreSQL CREATE TABLE LIKE imports - #1117
Open
yzxcj797 wants to merge 1 commit into
Open
Conversation
Expand LIKE clauses from earlier table definitions before SQL parsing, preserving extra columns, quoted identifiers, and statement text that the parser already supports. Unresolved sources are left unchanged rather than guessed.
|
@yzxcj797 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL
CREATE TABLE ... (LIKE ...)statements are valid, but the SQL parser used by diagram import does not understand them. This adds a PostgreSQL-specific preprocessing pass before parsing:CREATE TABLE;LIKE <known table>clause into that table's definition text;LIKEclause;A LIKE B, thenC LIKE A);LIKEsources unchanged rather than guessing a definition.The expansion runs only for PostgreSQL imports and does not alter source for other databases.
Testing
npm test— 4/4 tests passLIKE ... INCLUDING ALLnpm run lint— passes with zero warningsnpm run build— passes (existing lottie-web eval and large-chunk warnings remain)npx prettier --checkon the new files and package manifest — passesgit diff --check— passesFixes #471.