fix: center relationship labels vertically across browsers (Firefox + Chrome) - #1121
Open
Apageoflove wants to merge 1 commit into
Open
Conversation
… Chrome) - Use labelPoint.y directly with dominantBaseline="middle" instead of manual offset - Fixes Firefox misalignment reported in PR drawdb-io#1106 review - Works for both composite and simple relationship paths
|
@Apageoflove is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Firefox vertical alignment issue for relationship labels reported in PR #1106 review.
Changes
labelPoint.ydirectly withdominantBaseline="middle"instead of manuallabelPoint.y + labelHeight/2offsetlabelYandlabelHeightvariables entirelyRoot Cause
The previous approach calculated
labelY = labelPoint.y + labelHeight/2to fake vertical centering, but withoutdominantBaseline="middle", the text baseline positioning differs between Firefox and Chrome. The correct SVG approach is to setyto the exact center point and usedominantBaseline="middle"to let the browser handle vertical centering consistently.Closes #1045.