Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel Cashier upgrade rules #100

Closed
GeniJaho opened this issue Apr 10, 2023 · 2 comments
Closed

Laravel Cashier upgrade rules #100

GeniJaho opened this issue Apr 10, 2023 · 2 comments

Comments

@GeniJaho
Copy link
Collaborator

Can we include rules to upgrade Cashier to later versions like 13 and 14 in this repository? At least to handle the boring method renames and whatever work that can be automated.

Since it's a first-party Laravel package it would make sense to include it in this repo, but while adding new classes that are Cashier-specific, the Rector rules become bloated and hard to navigate.

A solution could be to prepend the rules with the Cashier prefix, for example, CashierStripeOptionsToStripeRector.

Or would a new repository be a better idea?

@driftingly
Copy link
Owner

I think prefixing is fine, groups related classes and allows for easy scanning.

@driftingly
Copy link
Owner

Closed by #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants