Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel Cashier 13 & 14 upgrade rules #103

Merged
merged 15 commits into from
Aug 16, 2023

Conversation

GeniJaho
Copy link
Collaborator

@GeniJaho GeniJaho commented Apr 29, 2023

Relates to #100

This PR introduces initial support for upgrading Laravel Cashier to version 13 and 14.

It only handles the method renames, since other upgrades are out of the scope (and capability) of Rector.

@GeniJaho
Copy link
Collaborator Author

Should I include the LaravelCashierSetList class somewhere? The CI fails since the class is currently unused in the project.

@GeniJaho GeniJaho marked this pull request as ready for review April 29, 2023 15:23
@driftingly
Copy link
Owner

@GeniJaho What do you think of having config/sets/packages/cashier-13.php?
If other package-specific sets are developed we could group them there?

@GeniJaho
Copy link
Collaborator Author

GeniJaho commented May 5, 2023

Yes, that would be a lot better. Any idea to make the failing check to pass? The CashierSetList class is not used anywhere.

@driftingly
Copy link
Owner

@GeniJaho sorry, that was my suggestion for the set list. Having something like what you did for Laravel 10:
https://github.com/driftingly/rector-laravel/blob/main/config/sets/level/up-to-laravel-100.php

@GeniJaho GeniJaho changed the title Add Laravel Cashier 13 upgrade rules Add Laravel Cashier 13 & 14 upgrade rules May 22, 2023
@driftingly
Copy link
Owner

@GeniJaho is this ready?
If it's ready to go can you merge in main and update the docs?
Thanks!

@GeniJaho
Copy link
Collaborator Author

@driftingly this is ready now, I updated the docs and main was merged. Not sure why that test failed before the merge though, I couldn't make it fail locally.

@driftingly driftingly merged commit eb9de6d into driftingly:main Aug 16, 2023
4 checks passed
@u01jmg3 u01jmg3 mentioned this pull request Aug 22, 2023
@GeniJaho GeniJaho deleted the laravel-cashier branch April 11, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants