-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core rector support - attempt #2 #122
Conversation
…plifiedAttributeRector
…ToBackHelperRector
…eToToRouteHelperRector.php
…InstanceWithHelperRector
@driftingly The last commit is really a 'downgrade' of the RequestStaticValidateToInjectRector rule. It now only works when we're looking at assignment statements ( I couldn't find a better way, but this solution worked in the few projects it tested it. |
Thanks for your work on this @GeniJaho Looks like some work was done on Might be able to use some of that for inspiration/direction. |
@driftingly Thank you so much for the tip, |
@GeniJaho Do those |
No, they were actually there before and are relevant to that Rule, the Rule should not affect usages in traits or extends. Fixtures for unchanged functionality don't need to define two identical parts, like this: <?php
$some = 'test';
?>
---
<?php
$some = 'test';
?> If we don't put a separator at all, that tells Rector that this piece of code shouldn't be changed. <?php
$some = 'test';
?> So I just simplified those two fixtures, they're appearing as new files, however. |
#120
#121
This PR fixes most of the errors preventing the upgrade up to Rector 0.17.6, except for RequestStaticValidateToInjectRector, which is turning out to be a different beast entirely. I'll try to fix it in a few days, maybe in another PR.