Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Into Pixi PR #4] Fix Dockerfiles #5
[Into Pixi PR #4] Fix Dockerfiles #5
Changes from all commits
7e1d3a7
a0e17dd
1285fe6
4e501f5
621fb5a
3f00c5a
b65ce71
9a61923
15547d4
f28d987
cc136a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this line copy
pixi.lock
over from the docker container back to the host?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--mount type=bind,source="$(shell pwd)"/runtime,target=/tmp \
mounts the localruntime/
directory into the container, so anything the container does happens directly to the host filesystem'sruntime/
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you tried running your original, but pretty sure you'd get an error because the
MAMBA_USER
environment variable does not exist.The
mambaorg/micromamba
base image is the thing that sets these environment variables and creates this user.https://github.com/mamba-org/micromamba-docker/blob/8a73165bd53a15445afd8e9c51a2137d1902b0ce/Dockerfile#L42-L49
Since we're not using it anymore, then we don't have a non-root runtime user. We need to create it ourselves. The lines further up in the Dockerfile create the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh I ran it without issue -- I wonder if it was somehow cached from when I built the image previously using the micromamba base. Either way, makes sense!