chore(blast-radius): exclude scripts/vscode/** from write-path derivation - #714
Merged
Merged
Conversation
…tion Every C# atomic plan cites the toolchain wrapper scripts under scripts/vscode/ (Invoke-MSTestWithCoverage.ps1, Invoke-Restore.ps1, Install-RepoDotNetSdk.ps1, etc.) as commands it runs, not files it writes -- the same shape mandate_reads already excludes for .claude/rules/** and quality-tiers.yml. Without this exclusion, blast-radius derivation treats every such citation as a genuine write-path overlap, manufacturing a spurious path_overlap conflict edge between every pair of C# parallel items. Observed in the bugs-638-644-647 parallel run: 21 of 91 recorded conflict edges rested on a scripts/vscode/ path citation alone. Multiple independent /parallel-add admission passes (items 285, 287, 648, 662, 663) flagged this exact gap and declined to work around it per the "never narrow a declared radius to suppress an edge" rule. This is a stopgap fix local to this repository; config/blast-radius.json is push-down-owned from drm-copilot and will be overwritten by the next push-down. The equivalent fix has been requested upstream in both the self-hosted and bundled copies there. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ATYLDoRLKXS5sgAzegW7ZL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested title
chore(blast-radius): exclude scripts/vscode/** from write-path derivation
Summary
"scripts/vscode/**"tomandate_readsinconfig/blast-radius.json.scripts/vscode/were being counted as write-path citations instead of run-path citations.config/blast-radius.jsonis push-down-owned fromdrm-copilotand will be overwritten by the next push-down cycle. The equivalent fix has separately been requested upstream.Why
Every C# atomic plan in this repository cites the toolchain wrapper scripts under
scripts/vscode/(Invoke-MSTestWithCoverage.ps1,Invoke-Restore.ps1,Install-RepoDotNetSdk.ps1, etc.) as commands it runs, not files it writes.mandate_readsalready excludes this exact shape of citation for.claude/rules/**andquality-tiers.yml(see.claude/rules/parallel-orchestration.md, "Read-by-mandate classification"), butscripts/vscode/**was missing from that list.Without the exclusion, blast-radius derivation treated every such citation as a genuine write-path overlap, manufacturing a spurious
path_overlapconflict edge between every pair of C# parallel items that cite the standard toolchain — which is effectively all of them.What Changed
Config
config/blast-radius.json: one entry added to themandate_readsarray.Architecture / How It Fits Together
mandate_readsis consumed byGet-BlastRadius/derive_blast_radiusto strip citations of mandated-reading paths out of a plan's harvested path list before conflict-edge computation, per the doctrine documented in.claude/rules/parallel-orchestration.md("Blast-Radius Contention Doctrine"). This change extends that exclusion set by one glob; no other logic changes.Verification
Completed
python -m json.tool).mandate_reads; no other keys touched.Recommended
Backward Compatibility / Migration Notes
None. This only narrows what counts as a citation-based conflict signal; it does not change scheduling for any item that genuinely writes a file under
scripts/vscode/— the planner remains obligated to declare such a write explicitly, per the existing mandate-read doctrine's constraint 1.Risks and Mitigations
scripts/vscode/could under-report its radius if the planner relies on the exclusion instead of declaring the write.Mitigation: the existing mandate-read doctrine already requires the planner to append a genuine write explicitly regardless of this exclusion (unchanged behavior), and drift detection compares the declared radius against paths actually touched, catching a real write against observed evidence.
Review Guide
Single-file, single-line diff. No suggested review order beyond the diff itself.
Follow-ups
drm-copilot, in both the self-hostedconfig/blast-radius.jsonand the bundledextensions/drm-copilot/resources/claude-customizations/config/blast-radius.json, kept byte-equal per the parity contract, so it survives the next push-down cycle instead of being silently reverted by it.GitHub Auto-close
None