Fixed SQLite version in CI. #643
Conversation
| @@ -12,7 +12,7 @@ env: | |||
|
|
|||
| jobs: | |||
| build: | |||
| runs-on: 'ubuntu-20.04' | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
i think we should run on latest by default. if needed - we can introduce running on older versions in another PR
| @@ -35,11 +35,20 @@ jobs: | |||
| - name: Checkout | |||
| uses: actions/checkout@v2 | |||
|
|
|||
| - name: Upgrade sqlite3 | |||
| run: | | |||
| wget https://www.sqlite.org/2024/sqlite-autoconf-3450300.tar.gz -O /tmp/sqlite.tar.gz | |||
There was a problem hiding this comment.
GHA images do not have the latest version of SQLite yet. We need to build it from source. This may need to be optimised later.
Will be removed once SQLite is added to GHA images
There was a problem hiding this comment.
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: ${{ matrix.php-versions }} | ||
| extensions: gd, pdo_sqlite | ||
| extensions: gd, sqlite, pdo_sqlite |
There was a problem hiding this comment.
explicitly call out sqlite as extension
| @@ -54,7 +63,7 @@ jobs: | |||
| run: composer --verbose install | |||
|
|
|||
| - if: matrix.drupal-release == 'dev' | |||
| run: composer --verbose require --no-update drupal/core-recommended:10.0.x-dev && composer --verbose require --no-update --dev drupal/core-dev:10.0.x-dev | |||
| run: composer --verbose require --no-update drupal/core-recommended:11.0.x-dev && composer --verbose require --no-update --dev drupal/core-dev:11.0.x-dev | |||
There was a problem hiding this comment.
this is an oversight that should have been addressed in my previous PR. sorry
| @@ -66,6 +75,6 @@ jobs: | |||
| - run: until curl -s $SIMPLETEST_BASE_URL; do true; done > /dev/null | |||
|
|
|||
| - name: Run a single unit test to verify the testing setup. | |||
| run: ./vendor/bin/phpunit -c ./web/core ./web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php | |||
| run: ./vendor/bin/phpunit -c ./web/core $(pwd)/web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php | |||
There was a problem hiding this comment.
Latest D11-dev changed the way the relative path discovered. Using absolute for now.
This change is not relevant to this project's functionality.
https://www.drupal.org/project/drupal/issues/3417066
and
https://www.drupal.org/project/drupal/issues/3445847
|
This PR does not affect the project functionality. I'm going to merge this to unblock CI so that others could test their submitted PRs with |
See inline comments for changes.
We did not have CI enabled for forks, so other PRs related to D11 did not run it. We now have CI running and catching things.