Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wreq'ing havoc ;P #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wreq'ing havoc ;P #141

wants to merge 1 commit into from
+33 −49

Conversation

The1Penguin
Copy link
Contributor

I felt that the current request system was a bit overkill, this should be a bit simpler in my opinion

@The1Penguin The1Penguin marked this pull request as ready for review October 18, 2024 16:23
malmz
malmz approved these changes Oct 18, 2024
View reviewed changes
Copy link

@malmz malmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change decreases the amount a haskell code in the codebase. I approve, great change!

SwedishSubmarine
SwedishSubmarine reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@SwedishSubmarine SwedishSubmarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't run it

10/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malmz malmz malmz approved these changes

@Multipacker Multipacker Multipacker approved these changes

@SwedishSubmarine SwedishSubmarine SwedishSubmarine approved these changes

@Rembane Rembane Awaiting requested review from Rembane

@rachelambda rachelambda Awaiting requested review from rachelambda

@erikOrtenberg erikOrtenberg Awaiting requested review from erikOrtenberg

@Discomannen Discomannen Awaiting requested review from Discomannen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@The1Penguin @malmz @Multipacker @SwedishSubmarine