Don't touch Python state from destructors that outlive the interpreter - #601
Open
alexander-beedie wants to merge 1 commit into
Open
Don't touch Python state from destructors that outlive the interpreter#601alexander-beedie wants to merge 1 commit into
alexander-beedie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #531.
(I have a very similar issue: getting "gilstate_tss_set" crashes after running
xdistpytests that use DuckDB and register custom UDFs, so was actively looking into this).Problem
DuckDBPyModuleStateis a function-local static, so its members can be destroyed after the interpreter is unusable; two destructors touch Python state from there:DefaultConnectionHolder::~DefaultConnectionHolderdrops ashared_ptr<DuckDBPyConnection>, whose destructor entersnb::gil_scoped_release→PyEval_SaveThread.PythonImportCache::~PythonImportCacheacquires the GIL to clear its refs.Both abort or segfault at shutdown (depending how the process ends).
Fix
Neither destructor should touch the interpreter once it is unreachable. So, the default connection is now leaked deliberately, and the import cache releases its references without freeing them. This cleanly resolves the crashes.
Tests
Added new test cases in
tests/fast/test_module.pythat can exercise the previously-crashing paths; each gets run by a subprocess.