Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable credentials import promo for all users #3427

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Oct 10, 2024

Task/Issue URL: https://app.asana.com/0/1202926619870900/1208282574906775/f

Description:

Just a BSK bump to allow for duckduckgo/macos-browser#3383

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme requested a review from amddg44 October 15, 2024 10:32
@graeme graeme marked this pull request as ready for review October 16, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants