Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tagline #3439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

New tagline #3439

wants to merge 1 commit into from

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Oct 15, 2024

Task/Issue URL: https://app.asana.com/0/1205591970852438/1208504563612286/f
Tech Design URL:
CC:

Description:

Updates new tagline. No user facing strings, but we might as well update the test data.

Steps to test this PR:
1.
2.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @quanganhdo and the rest of your teammates on Graphite Graphite

@quanganhdo quanganhdo marked this pull request as ready for review October 15, 2024 21:22
@quanganhdo quanganhdo requested review from a team and dus7 and removed request for a team October 15, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants