Remove MockDependencyProvider #3456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Oct 18, 2024
Comment on lines
+28
to
+40
| let subscriptionManager: SubscriptionManager = { | ||
| let accountManager = AccountManagerMock() | ||
| let subscriptionService = DefaultSubscriptionEndpointService(currentServiceEnvironment: .production) | ||
| let authService = DefaultAuthEndpointService(currentServiceEnvironment: .production) | ||
| let storePurchaseManager = DefaultStorePurchaseManager() | ||
| return SubscriptionManagerMock(accountManager: accountManager, | ||
| subscriptionEndpointService: subscriptionService, | ||
| authEndpointService: authService, | ||
| storePurchaseManager: storePurchaseManager, | ||
| currentEnvironment: SubscriptionEnvironment(serviceEnvironment: .production, | ||
| purchasePlatform: .appStore), | ||
| canPurchase: true) | ||
| }() |
There was a problem hiding this comment.
This could probably be done via some function to allow configuring the mocks, but since nothing needs that for now I haven't done it. Let me know if you'd prefer some other approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1208580381705388/f
Tech Design URL:
CC:
Description:
This PR removes
MockDependencyProviderand the ability to create testing instances ofAppDependencyProvider. Any test files that use it have been updated to take their dependencies directly.The only tests affected by this change are subscription ones;
DownloadManagerTestshad a mock dependency provider property, but it didn't appear to be used in any way.Steps to test this PR:
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template