Merging 1.93.0 changes back to main #2888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207613628544128/f BSK: duckduckgo/BrowserServicesKit#854 iOS: duckduckgo/iOS#2970 ## Description **Goals:** - Validate tunnel start prerequisites and, when they aren't met: - Prevent pixel noise; and - Prevent network calls to our backend. - Also clean up the code a bit so that we no longer use completion callbacks for the tunnel start logic.
|
Superseded by #2889. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207623703626203/f
Description
Merging back the changes from #2882 (1.93.0) to
mainTesting
Normally we do this without a PR since this has already been reviewed but I'm creating a PR to see the CI go green.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation