Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify secrets for pr.yml where called from another workflow #3137

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Aug 22, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1208100078742782/f

Steps to test this PR:

  1. Verify that CI is green.
  2. Verify that this workflow has started successfully (and failed at release branch assertion).

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested a review from aataraxiaa August 22, 2024 11:15
@ayoy ayoy merged commit b5d1040 into main Aug 22, 2024
29 of 31 checks passed
@ayoy ayoy deleted the dominik/gha-secrets-fix branch August 22, 2024 11:32
samsymons added a commit that referenced this pull request Aug 25, 2024
…iption

* main: (25 commits)
  Bump version to 1.103.0 (249)
  Bump version to 1.103.0 (248)
  Resolving automatic update edge cases (#3142)
  PIR Time-Based Pixel: 24 Opt-Out Request Success Rate (#2942)
  Freemium Local Package and Freemium State Implementation (#3118)
  Bump rexml from 3.3.3 to 3.3.6 (#3141)
  Filter out inaccessible tasks from release (#3133)
  Bump rexml from 3.2.9 to 3.3.3 (#3139)
  Bump version to 1.103.0 (247)
  Specify secrets for pr.yml where called from another workflow (#3137)
  Fix secrets usage in CI workflows (#3134)
  Adding info about how we improve our products to the README.md (#3135)
  Add Freemium PIR Feature Flag (#3129)
  Release notes page loading fix + Adding close button to the upgrade notification (#3094)
  App Configuration app group (#3132)
  Use code signing in CI tests workflows (#3125)
  'track' rephrased to 'anonymously track' (#3121)
  Additional PIR opt out confirmation pixels (#3119)
  Logging refactoring #1 Subscription and Content Blocking (#3091)
  Update RemoteMessagingDebugMenu to work on a private-queue context (#3120)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants