Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Common Logic to DBPUIDataBrokerProfileMatch for DBP UI Scan Results #3385

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Oct 10, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208507342220062/f

Description: This PR fixes an issue with Freemium PIR where the results displayed on the new tab page do not match the results displayed on the dashboard

Test Prerequisites

  1. Set yourself as an internal user via Debug menu → Set Internal User State
  2. Disable/Signout of Privacy Pro via Settings menu → PP → Remove from this device
  3. Select Debug menu → Freemium -> Enroll into Experiment
  4. Set the custom frontend UI URL via Debug menu → Personal Information Removal → Web UI → Set Custom URL. Enter https://abrown.duckduckgo.com/dbp
  5. Use the custom frontend UI URL via Debug menu → Personal Information Removal → Web UI → Use Custom URL
    Relaunch the browser

Steps to test this PR:

  1. Relaunch the browser
  2. Open Freemium PIR via the banner on the new tab page
  3. Enter profile data and perform a scan
  4. Wait until it completes (or gets stuck 😅, a separate issue)
  5. Note the scan results - the count of matches and broker sites (e.g 20 matches on 14 sites)
  6. Relaunch the browser
  7. You should see a banner on the new tab page and the results should match the previous results from the PIR dashboard

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@aataraxiaa aataraxiaa marked this pull request as ready for review October 10, 2024 16:52
Copy link
Member

@quanganhdo quanganhdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked very well 👏 (the scan progress still gets stuck tho 🥲)

@aataraxiaa aataraxiaa merged commit 9eb88c3 into pete/feature/pir-freemium Oct 11, 2024
35 checks passed
@aataraxiaa aataraxiaa deleted the pete/feature/pir-freemium-bugfix-scan-results-calculation branch October 11, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants