Add Phishing Detection Embedded Data Update Workflow #3403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208270234071172/f
Tech Design URL: https://app.asana.com/0/481882893211075/1207483114414814
CC:
Description:
In ✓ Tech Design: Phishing Protection Data Updates we defined an approach to get embedded data for phishing protection into the app builds. This pattern was implemented, but two small components still need merging:
Note
After testing, but before merging, I'd like to update the GH action to run on a schedule once per week using cron:
This way it can be reviewed just once per week by whoever is on maintenance that week as part of the weekly maintenance rota.
Steps to test this PR:
bash scripts/update_phishing_data.sh
DuckDuckGo/PhishingDetection/PhishingDetection.swift
- sha256 and version values updated correctlyDuckDuckGo/PhishingDetection/filterSet.json
- not emptyDuckDuckGo/PhishingDetection/hashPrefixes.json
- not emptyUpdate phishing protection datasets to 1681795
:Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation