Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS multiuser support for our browser #3416

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Oct 18, 2024

Task/Issue URL: https://app.asana.com/0/0/1208568093882532/f

Description

Fix macOS multiuser support for our browser

Testing

A testing build is available here.

  1. Run it on one user in macOS
  2. Log into a separate macOS user and open the app again, make sure it launches

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez changed the base branch from main to release/1.110.0 October 18, 2024 10:04
@diegoreymendez diegoreymendez marked this pull request as ready for review October 18, 2024 10:24
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @diegoreymendez! I was able to launch the app as another user, while the current production app couldn't be launched. All good 🚢 🇮🇹

@diegoreymendez diegoreymendez merged commit 86d3e43 into release/1.110.0 Oct 18, 2024
36 checks passed
@diegoreymendez diegoreymendez deleted the diego/fix-multiuser branch October 18, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants