Add NTP Customization Settings onboarding popover #3428
+347
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
commented
Oct 21, 2024
Comment on lines
+66
to
+70
| if let title = viewModel.title { | ||
| messageWithTitleBody(title) | ||
| } else { | ||
| messageBody | ||
| } |
There was a problem hiding this comment.
The change to this file is the support for title parameter.
When title is present, we display a different message body, consisting of title and message.
When title is not present, we display the old view with just the message.
ayoy
commented
Oct 21, 2024
|
|
||
| @State var isHovering: Bool = false | ||
| @Binding var isSettingsVisible: Bool |
There was a problem hiding this comment.
This has been removed in favor of using settingsVisibilityModel.
ayoy
force-pushed
the
dominik/ntp-search-bar-settings-cta
branch
from
0ef80c9
to
56e51ee
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208583505730578/f
Description:
This change adds a popover that is displayed once for every user over the 'Customize' button on the NTP.
It's not a part of the experiment nor it's related to the search bar project. We're adding the onboarding to
increase engagement with NTP customization settings.
Steps to test this PR:
DefaultNewTabPageSearchBoxExperimentCohortDecider.cohortgetter body to justreturn .experimentDefinition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation