Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker development volumes location for the 20-app.dev.ini file #652

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Trim
Copy link
Contributor

@Trim Trim commented Aug 8, 2024

With the fix to load app's ini files after all other extensions are loaded (#617), the app-dev.ini file has been renamed 20-app.dev.ini and has been moved to a folder named "app.conf.d".

Although, the fix forgot to update the development environment file compose.override.yaml with the new name and location.

…i file

With the fix to load app's ini files after all other extensions are loaded (dunglas#617), the app-dev.ini file has been renamed 20-app.dev.ini and has been moved to a folder named "app.conf.d".

Although, the fix forgot to update the development environment file `compose.override.yaml` with the new name and location.
@Trim
Copy link
Contributor Author

Trim commented Aug 8, 2024

Without this fix, docker raises this error:

$ docker compose up
[+] Running 1/0
 ✔ Container symfony-docker-php-1  Recreated                                                                                                                                                                                                                                                                                                                                                                                          0.1s
Attaching to php-1
Gracefully stopping... (press Ctrl+C again to force)
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/tmp/symfony-docker/frankenphp/conf.d/app.dev.ini" to rootfs at "/usr/local/etc/php/conf.d/app.dev.ini": mount /tmp/symfony-docker/frankenphp/conf.d/app.dev.ini:/usr/local/etc/php/conf.d/app.dev.ini (via /proc/self/fd/7), flags: 0x5000: not a directory: unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type

@dunglas dunglas merged commit 32b95a1 into dunglas:main Aug 8, 2024
2 checks passed
@dunglas
Copy link
Owner

dunglas commented Aug 8, 2024

Thanks!

VitaliyMinenko pushed a commit to VitaliyMinenko/notofication-service that referenced this pull request Sep 16, 2024
…dunglas#652)

With the fix to load app's ini files after all other extensions are loaded (dunglas#617), the app-dev.ini file has been renamed 20-app.dev.ini and has been moved to a folder named "app.conf.d".

Although, the fix forgot to update the development environment file `compose.override.yaml` with the new name and location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants