Skip to content

Commit

Permalink
renamed setAttribute to setAttributeObject and addSubTag to addSubTag…
Browse files Browse the repository at this point in the history
…Object in order to clarify that the argument should be an object not a string. And it differentiates these methods and their signatures from the similarly named methods in the Htmlfactory library which take strings as arguments and makes the objects on the fly.
  • Loading branch information
dwilbourne committed Oct 19, 2024
1 parent 3574af1 commit 41a32a5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/html/tag/TagInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ public function setAllowedSubtags(array $subTagNames): void;
public function getAllowedSubTags(): array;

/**
* addSubTag
* addSubTagObject
* @param TagVoidInterface $tag
*/
public function addSubTag(TagVoidInterface $tag): void;
public function addSubTagObject(TagVoidInterface $tag): void;

/**
* setInnerTextAllowed
Expand Down
4 changes: 2 additions & 2 deletions src/html/tag/TagVoidInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ public function setAllowedAttributes(array $allowedAttributes): void;
public function getAllowedAttributes(): array;

/**
* setAttribute
* setAttributeObject
* @param AttributeVoidInterface $attribute
* @return TagVoidInterface
*/
public function setAttribute(AttributeVoidInterface $attribute): TagVoidInterface;
public function setAttributeObject(AttributeVoidInterface $attribute): TagVoidInterface;

/**
* getAttribute
Expand Down

0 comments on commit 41a32a5

Please sign in to comment.