refactor: Change method getUsserAdvertisement

eTachkaMarketplace · Jan 24, 2024 · 9b8f391 · 9b8f391
1 parent 5d31353
commit 9b8f391
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/main/java/com/sellbycar/marketplace/ad/AdvertisementRepository.java b/src/main/java/com/sellbycar/marketplace/ad/AdvertisementRepository.java
@@ -9,4 +9,6 @@
 public interface AdvertisementRepository extends JpaRepository<AdvertisementDAO, Long>, JpaSpecificationExecutor<AdvertisementDAO> {
 
     @NonNull List<AdvertisementDAO> findAll();
+
+    @NonNull List<AdvertisementDAO> findByUserId(Long userId);
 }
diff --git a/src/main/java/com/sellbycar/marketplace/ad/AdvertisementServiceImpl.java b/src/main/java/com/sellbycar/marketplace/ad/AdvertisementServiceImpl.java
@@ -148,16 +148,13 @@ public void removeAdvertisement(Long id) {
     @Transactional
     public List<AdvertisementDTO> getUserAdvertisement() {
         UserDAO user = userService.getUserFromSecurityContextHolder();
-        List<AdvertisementDAO> advertisements = advertisementRepository.findAll();
-        if (advertisements.stream().anyMatch(adv -> adv.getUser().getId().equals(user.getId()))) {
-            return advertisements.stream()
-                    .map(advertisementMapper::toDTO)
-                    .collect(Collectors.toList());
-        } else {
-            throw new RequestException("Insufficient privileges", HttpStatus.FORBIDDEN);
-        }
+        List<AdvertisementDAO> advertisements = advertisementRepository.findByUserId(user.getId());
+        return advertisements.stream()
+                .map(advertisementMapper::toDTO)
+                .collect(Collectors.toList());
     }
 
+
     @Transactional
     public void enableAdvertisement(Long id) {
         UserDAO existingUser = userService.getUserFromSecurityContextHolder();