Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build command #11

Closed
wants to merge 3 commits into from
Closed

Fix build command #11

wants to merge 3 commits into from

Conversation

vgeorge
Copy link
Collaborator

@vgeorge vgeorge commented May 3, 2023

Currently the yarn build command is failing, and we need to fix it to be able to deploy the app.

I added the following fixes:

  • Removed the prototype folder
  • Load counties geojson from the database instead of geojson file

There is still an error ocurring in _map component, looks related to Deck imports.

This is work in progress, opening for visibility.

cc @nerik

@nerik
Copy link
Contributor

nerik commented May 3, 2023

@vgeorge I've fixed the build. It is indeed an issue with deck.gl, that I fixed by downgrading deck.gl to the previous minor. This is a hack, we'll need to figure out a better way - see

Load counties geojson from the database instead of geojson file

I took a slightly different approach here: #9
I wanted to use TopoJSON because the file is so much smaller than GeoJSON, but for now, this is still working with a static file. I think the file size is going to be an issue with GeoJSON, so it's either:

  • we pull geoms from the db as TopoJSON (AsTopoJSON exists but I'm not sure it's worth the effort)
  • we keep the static file and use the DB table only to query individual feature properties

@vgeorge
Copy link
Collaborator Author

vgeorge commented May 3, 2023

@nerik thanks for looking into fixing this. I think it makes a lot of sense to use a TopoJSON, lets discuss on a separate ticket how to generate it. I'm closing this in favor of #9, the PR that includes your fix.

@vgeorge vgeorge closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants