Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lib,tools}[foss/2023a,gfbf/2023a] PyTorch3D v0.7.8, visdom v0.2.4 w/ CUDA 12.1.1 #21763

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

VRehnberg
Copy link
Contributor

@VRehnberg VRehnberg commented Oct 29, 2024

(created using eb --new-pr)

@VRehnberg VRehnberg marked this pull request as draft October 29, 2024 13:50
@VRehnberg
Copy link
Contributor Author

VRehnberg commented Oct 30, 2024

Aborted, for hanging.


Test report by @VRehnberg
FAILED
Failed during parsing of the easyconfigs, so no ecs were built (1 easyconfigs in total)
alvis10-07 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 4 x NVIDIA NVIDIA A40, 560.35.03, Python 3.6.8
See https://gist.github.com/VRehnberg/a71512f22b28ff35126086c7a30565af for a full test report.

@VRehnberg VRehnberg changed the title {lib,tools}[foss/2023a,gfbf/2023a] PyTorch3D v0.7.7, visdom v0.2.4 w/ CUDA 12.1.1 {lib,tools}[foss/2023a,gfbf/2023a] PyTorch3D v0.7.8, visdom v0.2.4 w/ CUDA 12.1.1 Nov 4, 2024
Copy link

github-actions bot commented Nov 7, 2024

Updated software PyTorch3D-0.7.8-foss-2023a-CUDA-12.1.1.eb

Diff against PyTorch3D-0.4.0-fosscuda-2020b-PyTorch-1.7.1.eb

easybuild/easyconfigs/p/PyTorch3D/PyTorch3D-0.4.0-fosscuda-2020b-PyTorch-1.7.1.eb

diff --git a/easybuild/easyconfigs/p/PyTorch3D/PyTorch3D-0.4.0-fosscuda-2020b-PyTorch-1.7.1.eb b/easybuild/easyconfigs/p/PyTorch3D/PyTorch3D-0.7.8-foss-2023a-CUDA-12.1.1.eb
index 28c09209b9..a98cf39994 100644
--- a/easybuild/easyconfigs/p/PyTorch3D/PyTorch3D-0.4.0-fosscuda-2020b-PyTorch-1.7.1.eb
+++ b/easybuild/easyconfigs/p/PyTorch3D/PyTorch3D-0.7.8-foss-2023a-CUDA-12.1.1.eb
@@ -1,50 +1,120 @@
-# This easyconfig was created by the BEAR Software team at the University of Birmingham.
 easyblock = 'PythonBundle'
 
 name = 'PyTorch3D'
-version = '0.4.0'
-local_pytorch_version = '1.7.1'
-versionsuffix = '-PyTorch-%s' % local_pytorch_version
+version = '0.7.8'
+versionsuffix = '-CUDA-%(cudaver)s'
 
 homepage = "https://pytorch3d.org/"
 description = """PyTorch3D is FAIR's library of reusable components for deep learning with 3D data."""
 
-toolchain = {'name': 'fosscuda', 'version': '2020b'}
+toolchain = {'name': 'foss', 'version': '2023a'}
+
+builddependencies = [
+    # Building
+    ('hatchling', '1.18.0'),
+    # Testing
+    ('Python-bundle-PyPI', '2023.06'),  # pytest
+    ('scikit-image', '0.22.0'),
+    ('OpenCV', '4.8.1', versionsuffix + '-contrib'),
+    ('plotly.py', '5.16.0'),
+    ('SQLAlchemy', '2.0.25'),
+    ('visdom', '0.2.4'),
+]
 
 dependencies = [
-    ('Python', '3.8.6'),
-    ('tqdm', '4.56.2'),
-    ('PyTorch', local_pytorch_version),
-    ('imageio', '2.9.0'),
-    ('IPython', '7.18.1'),
-    ('torchvision', '0.8.2', versionsuffix),
+    ('Python', '3.11.3'),
+    ('CUDA', '12.1.1', '', SYSTEM),
+    ('tqdm', '4.66.1'),
+    ('PyTorch-bundle', '2.1.2', versionsuffix),  # for portalocker, torchvision
+    ('imageio', '2.33.1'),
+    ('IPython', '8.14.0'),
+    ('PyOpenGL', '3.1.7'),
+    ('PyCUDA', '2024.1', versionsuffix),
 ]
 
 sanity_pip_check = True
 use_pip = True
 
 exts_list = [
-    ('portalocker', '2.3.0', {
-        'checksums': ['4e913d807aa6598c320e8a50c50e2ee0602bc45240b485e3f8bc06f13060084c'],
-    }),
-    ('termcolor', '1.1.0', {
-        'checksums': ['1d6d69ce66211143803fbc56652b41d73b4a400a2891d7bf7a1cdf4c02de613b'],
+    ('termcolor', '2.3.0', {
+        'checksums': ['b5b08f68937f138fe92f6c089b99f1e2da0ae56c52b78bf7075fd95420fd9a5a'],
     }),
     ('yacs', '0.1.8', {
         'checksums': ['efc4c732942b3103bea904ee89af98bcd27d01f0ac12d8d4d369f1e7a2914384'],
     }),
-    ('iopath', '0.1.8', {
-        'source_tmpl': '%(namelower)s-%(version)s-py3-none-any.whl',
-        'unpack_sources': False,
-        'checksums': ['e11029c30ee77616b3efd82888aa80941d12afcc5940c2ef57e04a8e93a10f9f'],
+    ('iopath', '0.1.10', {
+        'checksums': ['3311c16a4d9137223e20f141655759933e1eda24f8bff166af834af3c645ef01'],
     }),
-    ('fvcore', '0.1.5.post20210617', {
-        'checksums': ['1f1fb91b82166f85ed0f7da8906e87688de9e1b4879b478dc3969d93d24f0379'],
+    ('antlr4-python3-runtime', '4.9.3', {
+        'modulename': 'antlr4',
+        'checksums': ['f224469b4168294902bb1efa80a8bf7855f24c99aef99cbefc1bcd3cce77881b'],
+    }),
+    ('omegaconf', '2.3.0', {
+        'checksums': ['d5d4b6d29955cc50ad50c46dc269bcd92c6e00f5f90d23ab5fee7bfca4ba4cc7'],
+    }),
+    ('lpips', '0.1.4', {
+        'checksums': ['3846331df6c69688aec3d300a5eeef6c529435bc8460bd58201c3d62e56188fa'],
     }),
     (name, version, {
-        'source_tmpl': 'v%(version)s.tar.gz',
+        'patches': [
+            'PyTorch3D-0.7.8_fix-opengl-test-hang.patch',
+            'PyTorch3D-0.7.8_use-installdir-in-test.patch',
+            'PyTorch3D-0.7.8_squeeze-1-channel-imgs-in-test.patch',
+            'PyTorch3D-0.7.8_bar-dataclass-immutable-in-test.patch',
+            'PyTorch3D-0.7.8_remove-relative-sys-path-insert.patch',
+            'PyTorch3D-0.7.8_fix-kwarg-only-in-test.patch',
+            'PyTorch3D-0.7.8_fix-test_io_off-np-error-msg.patch',
+            'PyTorch3D-0.7.8_fix-data_path-in-test-cow.patch',
+        ],
+        'source_tmpl': 'V%(version)s.tar.gz',
         'source_urls': ['https://github.com/facebookresearch/%(namelower)s/archive'],
-        'checksums': ['6f33c45c8b698b068ff267287ad490dc2f8f48ad2f486175438b0426575e391a'],
+        'checksums': [
+            {'V0.7.8.tar.gz': 'd91298b17ec203fbcea62587e4e9c36b1ef717f98114d6919ff9acece5ea0f99'},
+            {'PyTorch3D-0.7.8_fix-opengl-test-hang.patch':
+             'f23cac69535f4c72857688b9fcb8dbd1813a857653ea38e84d958e212b45d139'},
+            {'PyTorch3D-0.7.8_use-installdir-in-test.patch':
+             '02298334e742c6cf85c4656afe706530dad9bf91ff75cc39d221a8621bd398b2'},
+            {'PyTorch3D-0.7.8_squeeze-1-channel-imgs-in-test.patch':
+             'b0ae109c4cce9cfdb7eeab7155b826944a1ffdbd9613c3ba217d310614642d59'},
+            {'PyTorch3D-0.7.8_bar-dataclass-immutable-in-test.patch':
+             '82d1162410b8217557dffba9c1bbb21db3f9eaccaa1398cba4c0fa74ff50cf69'},
+            {'PyTorch3D-0.7.8_remove-relative-sys-path-insert.patch':
+             'b1f1da4a9b610a139c13efb733e564d17213daa714cbd83dcf3217ea68687936'},
+            {'PyTorch3D-0.7.8_fix-kwarg-only-in-test.patch':
+             '4a1036e9c3a51655155d88a86051f6469a10fbbb5d2dee57dc0fefba9b95e5bf'},
+            {'PyTorch3D-0.7.8_fix-test_io_off-np-error-msg.patch':
+             '72a2c811783bdb30615fbc25ae0c550718a5fa0c65d5eb6bfafa43330a770d96'},
+            {'PyTorch3D-0.7.8_fix-data_path-in-test-cow.patch':
+             'e08380207e4eb994cece7d3b052ecc21358695b267c0dd52b9c630830d3a66b8'}
+
+        ],
+        'testinstall': True,
+        'runtest': (
+            # Running in srcdir will make pytorch3d overshadow testinstall
+            'ln -s $PWD/tests/ ../tests'
+            ' && ln -s $PWD/docs ../docs'  # includes data used in tests
+            ' && ln -s $PWD/website ../website'  # used in test_build (consider skipping instead)
+            ' && cd ../'
+            # Run tests
+            ' && pytest -ra tests/'
+            # Flaky (see https://github.com/facebookresearch/pytorch3d/issues/1914)
+            ' --deselect=tests/test_knn.py::TestKNN::test_knn_vs_python_square_cuda'
+            ' --deselect=tests/test_points_alignment.py::TestICP::test_heterogeneous_inputs'
+            ' --deselect=tests/test_render_meshes.py::TestRenderMeshes::test_simple_sphere_elevated_camera'
+            # Requires multiple GPUs
+            #' --deselect=tests/test_pointclouds.py::TestPointclouds::test_to_list'
+            #' --deselect=tests/test_pointclouds.py::TestPointclouds::test_to_tensor'
+            #' --deselect=tests/test_render_multigpu.py::TestRenderMeshesMultiGPU::test_mesh_renderer_opengl_to'
+            #' --deselect=tests/test_render_multigpu.py::TestRenderMeshesMultiGPU::test_mesh_renderer_to'
+            #' --deselect=tests/test_render_multigpu.py::TestRenderMeshesMultiGPU::test_render_meshes'
+            #' --deselect=tests/test_render_multigpu.py::TestRenderMeshesMultiGPU::test_render_meshes_opengl'
+            #' --deselect=tests/test_rendering_utils.py::TestTensorProperties::test_to'
+            # Something is wrong with test_opengl_utils.py, run separately
+            ' --ignore=tests/test_opengl_utils.py'
+            ' && pytest -ra tests/test_opengl_utils.py'
+            # Seems harmless, see https://github.com/facebookresearch/pytorch3d/issues/1759#issuecomment-2003868471
+            ' --deselect tests/test_opengl_utils.py::TestOpenGLUtils::test_no_egl_error'
+        ),
     }),
 ]
 

Updated software visdom-0.2.4-gfbf-2023a.eb

Diff against visdom-0.2.4-foss-2022a.eb

easybuild/easyconfigs/v/visdom/visdom-0.2.4-foss-2022a.eb

diff --git a/easybuild/easyconfigs/v/visdom/visdom-0.2.4-foss-2022a.eb b/easybuild/easyconfigs/v/visdom/visdom-0.2.4-gfbf-2023a.eb
index 213fb90e29..2863b75524 100644
--- a/easybuild/easyconfigs/v/visdom/visdom-0.2.4-foss-2022a.eb
+++ b/easybuild/easyconfigs/v/visdom/visdom-0.2.4-gfbf-2023a.eb
@@ -8,31 +8,31 @@ description = """
 A flexible tool for creating, organizing, and sharing visualizations of live,
 rich data. Supports Torch and Numpy."""
 
-toolchain = {'name': 'foss', 'version': '2022a'}
+toolchain = {'name': 'gfbf', 'version': '2023a'}
 
 dependencies = [
-    ('Python', '3.10.4'),
-    ('SciPy-bundle', '2022.05'),
-    ('networkx', '2.8.4'),
-    ('Pillow-SIMD', '9.2.0'),
+    ('Python', '3.11.3'),
+    ('SciPy-bundle', '2023.07'),
+    ('networkx', '3.1'),
+    ('Pillow-SIMD', '9.5.0'),
 ]
 
 use_pip = True
 sanity_pip_check = True
 
 exts_list = [
-    ('tornado', '6.2', {
-        'checksums': ['9b630419bde84ec666bfd7ea0a4cb2a8a651c2d5cccdbdd1972a0c859dfc3c13'],
+    ('tornado', '6.3.2', {
+        'checksums': ['4b927c4f19b71e627b13f3db2324e4ae660527143f9e1f2e2fb404f3a187e2ba'],
     }),
-    ('jsonpointer', '2.3', {
-        'checksums': ['97cba51526c829282218feb99dab1b1e6bdf8efd1c43dc9d57be093c0d69c99a'],
+    ('jsonpointer', '2.4', {
+        'checksums': ['585cee82b70211fa9e6043b7bb89db6e1aa49524340dde8ad6b63206ea689d88'],
     }),
-    ('jsonpatch', '1.32', {
-        'checksums': ['b6ddfe6c3db30d81a96aaeceb6baf916094ffa23d7dd5fa2c13e13f8b6e600c2'],
+    ('jsonpatch', '1.33', {
+        'checksums': ['9fcd4009c41e6d12348b4a0ff2563ba56a2923a7dfee731d004e212e1ee5030c'],
     }),
-    ('websocket-client', '1.5.1', {
+    ('websocket-client', '1.7.0', {
         'modulename': 'websocket',
-        'checksums': ['3f09e6d8230892547132177f575a4e3e73cfdf06526e20cc02aa1c3b47184d40'],
+        'checksums': ['10e511ea3a8c744631d3bd77e61eb17ed09304c413ad42cf6ddfa4c7787e8fe6'],
     }),
     (name, version, {
         'checksums': ['84a911d3c8814a056d54812b381bd938cb44bcfc503a85fe0f701502bb720574'],

@github-actions github-actions bot added the update label Nov 7, 2024
@VRehnberg VRehnberg marked this pull request as ready for review November 7, 2024 11:53
@VRehnberg
Copy link
Contributor Author

VRehnberg commented Nov 7, 2024

Test report by @VRehnberg
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
alvis5-15 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 4 x NVIDIA NVIDIA A40, 560.35.03, Python 3.6.8
See https://gist.github.com/VRehnberg/58e900ddd2da73ae6cdf0a1f50dfa0ed for a full test report.


Edit:
Failed in applying patches. Patch level could not be determined for patch adding tests/conftest.py

@VRehnberg
Copy link
Contributor Author

VRehnberg commented Nov 7, 2024

Test report by @VRehnberg
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-icelake-build - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/VRehnberg/a46c812ad90a841922c61bad9d3a60f7 for a full test report.


Edit:
Running --stop=patch works on the other hand 🤔

@VRehnberg
Copy link
Contributor Author

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis3-18 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 1 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.6.8
See https://gist.github.com/VRehnberg/0fe5d6ae6133795e0d8a6f0c2c0f804b for a full test report.

@VRehnberg
Copy link
Contributor Author

Test report by @VRehnberg
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
alvis4-21 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 1 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.6.8
See https://gist.github.com/VRehnberg/d0725a83ff7fd95630e4d8d0fae4fafd for a full test report.

@VRehnberg
Copy link
Contributor Author

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis5-12 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 4 x NVIDIA NVIDIA A40, 560.35.03, Python 3.6.8
See https://gist.github.com/VRehnberg/224c235045a673012634bfaa5fb63347 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant