Skip to content

Commit

Permalink
* popover: prevent to layout on popover is hidden or destroyed.
Browse files Browse the repository at this point in the history
  • Loading branch information
catouse committed Aug 21, 2024
1 parent 10c26be commit 6b5df38
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/popover/src/vanilla/popover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,9 @@ export class Popover<O extends PopoverOptions = PopoverOptions, E extends Compon
}

this._layoutWatcher = autoUpdate(trigger, target, () => {
if (this.destroyed || !this._shown) {
return;
}
const {animation, name = 'popover', minWidth, minHeight, limitInScreen, onLayout} = this.options;

Check warning on line 330 in lib/popover/src/vanilla/popover.ts

View workflow job for this annotation

GitHub Actions / deploy

'onLayout' is assigned a value but never used
if (!this._virtual) {
const style: JSX.CSSProperties = {};
Expand Down

0 comments on commit 6b5df38

Please sign in to comment.