ci: fix docs build in PRs - #558
Closed
AlexanderLanin wants to merge 1 commit into
Closed
Conversation
AlexanderLanin
requested a deployment
to
workflow-approval
August 28, 2026 10:04 — with
GitHub Actions
Waiting
AlexanderLanin
requested a deployment
to
workflow-approval
August 28, 2026 10:04 — with
GitHub Actions
Waiting
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
danth
suggested changes
Aug 28, 2026
Member
There was a problem hiding this comment.
We are waiting for merge queue to be enabled by eclipse-score/.eclipsefdn#214, after that the summary job in on-pr.yml will be the only one which is marked as required.
Therefore I would recommend adding these jobs to on-pr.yml and making the summary job depend on them, otherwise the merge queue will ignore the docs build.
Member
Author
There was a problem hiding this comment.
problems:
- extend on-pr.yml to be triggered on release
- documentation publish would depend on the slowest job in on-pr, instead of publishing as soon as documentation is available
alterative:
- add docs build to .eclipsefdn as well
Contributor
|
Fixed on #561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately I need to abandon this half way through for today
Resolves #557