Skip to content

Remove test end file - #564

Merged
MaciejKaszynski merged 1 commit into
eclipse-score:mainfrom
etas-contrib:no-test-end-file
Sep 1, 2026
Merged

Remove test end file#564
MaciejKaszynski merged 1 commit into
eclipse-score:mainfrom
etas-contrib:no-test-end-file

Conversation

@danth

@danth danth commented Aug 28, 2026

Copy link
Copy Markdown
Member

Previously, the Python script would poll for the existence of a test end file, which was created by the control client test driver. The Python script would send SIGTERM to launch manager once the file appeared.

Now, the control client test driver just sends SIGTERM directly to launch manager.

This setup has been a source of flakiness in the past, so removing it may help. Also, it allows us to drop a patch on ITF as we are no longer affected by that bug.

Thanks to @MaciejKaszynski for exploring this the other day 😄

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: e8e9ee55-558a-4895-bacb-759837bba8c8
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (41 packages loaded, 10 targets configured)

Analyzing: target //:license-check (131 packages loaded, 366 targets configured)

Analyzing: target //:license-check (155 packages loaded, 5133 targets configured)

Analyzing: target //:license-check (160 packages loaded, 6259 targets configured)

Analyzing: target //:license-check (165 packages loaded, 6308 targets configured)

Analyzing: target //:license-check (165 packages loaded, 6308 targets configured)

Analyzing: target //:license-check (168 packages loaded, 9533 targets configured)

Analyzing: target //:license-check (172 packages loaded, 11429 targets configured)

INFO: Analyzed target //:license-check (173 packages loaded, 11555 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 23.748s, Critical Path: 0.35s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@danth
danth deployed to workflow-approval August 28, 2026 15:59 — with GitHub Actions Active
@danth
danth deployed to workflow-approval August 28, 2026 15:59 — with GitHub Actions Active
Comment thread tests/integration/complex_monitoring/complex_monitoring.py Outdated
Comment thread tests/integration/complex_monitoring/complex_monitoring.py
@danth
danth force-pushed the no-test-end-file branch from 9459c6c to b3e416a Compare August 31, 2026 09:01
@danth
danth deployed to workflow-approval August 31, 2026 09:01 — with GitHub Actions Active
@danth
danth deployed to workflow-approval August 31, 2026 09:01 — with GitHub Actions Active
@danth
danth requested a review from MaciejKaszynski August 31, 2026 09:03
@danth
danth deployed to workflow-approval September 1, 2026 12:22 — with GitHub Actions Active
@danth
danth deployed to workflow-approval September 1, 2026 12:22 — with GitHub Actions Active
MaciejKaszynski
MaciejKaszynski previously approved these changes Sep 1, 2026
Previously, the Python script would poll for the existence of a
test end file, which was created by the control client test driver.
The Python script would send `SIGTERM` to launch manager once the
file appeared.

Now, the control client test driver just sends `SIGTERM` directly
to launch manager.

This setup has been a source of flakiness in the past, so removing
it may help. Also, it allows us to drop a patch on ITF as we are no
longer affected by that bug.
@MaciejKaszynski
MaciejKaszynski merged commit c30f0f3 into eclipse-score:main Sep 1, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Sep 1, 2026
@danth
danth deleted the no-test-end-file branch September 1, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants